Support awaiting additional engine callbacks #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add EngineCallbackTiming enumeration with support for Application.onBeforeRender, Canvas.willRenderCanvases & Canvas.preWillRenderCanvases callbacks. Extract PlayerLoopRunner core logic into new base class ContinuationRunner. Add new EngineCallbackRunner class for running callbacks supported by EngineCallbackTiming enum. Modify YieldPromise to support creating a promise for the new enum.
Canvas.preWillRenderCanvases callback is available in 2020.3.0 and later
|
It doesn't seem like an appropriate scenario to make it awaitable with UniTask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request adds the ability for a task to
awaitthe invocation of some additional Unity callbacks:Application.onBeforeRendervia methodUniTask.WaitForOnBeforeRenderCanvas.willRenderCanvasesvia methodUniTask.WaitForWillRenderCanvasesCanvas.preWillRenderCanvasesvia methodUniTask.WaitForPreWillRenderCanvasesImplementation notes:
EngineCallbackTimingdefines these callbacks (similar toPlayerLoopTiming) with theInjectEngineCallbackTimingscounterpart. - I figured it was best to keep these separated since they do not use the PlayerLoop.PlayerLoopRunnerinto new base classContinuationRunnerso it could be shared with new classEngineCallbackRunnerfor these callbacks.WaitFormethods utilizeYieldPromisewhich was changed to accommodate the new enum with minimal changes.