-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New generic TabView with drag and drop + state fix #1535
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # CodeEdit.xcodeproj/project.pbxproj # CodeEdit/Features/UtilityArea/TerminalUtility/UtilityAreaTerminalView.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments
@@ -61,3 +85,9 @@ enum NavigatorTab: AreaTab { | |||
} | |||
} | |||
} | |||
|
|||
import UniformTypeIdentifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports should be at the top of the file.
|
||
extension AnyVariadicView.Subview { | ||
var onMove: ((IndexSet, Int) -> Void)? { | ||
self["s7SwiftUI14OnMoveTraitKeyV", as: ((IndexSet, Int) -> Void).self] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are mad sketchy, can we add a test for this so we can be notified quickly if they change in a future SwiftUI release?
@CodeEditApp/maintainers What do we want to do with this at this point? |
Description
A new ReorderableTabView, which replaces AreaTabBarAlt.
Why?
Note that this PR adds the possibility to add all this functionality, but doesn't implement all of it. For example, global drag and drop is possible (and is enabled for the navigator), but isn't used yet as a second navigator tabview isn't present yet. Thanks to this PR, it can be added later on with just a few code changes.
Checklist
Related issues