-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to load grid when using external postgres #13714
Unable to load grid when using external postgres #13714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving backend half of this, with a few small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm happy to leave the offset timezone changes in if that fixed an issue for you. There is probably some scenario that works with the old code, but hopefully usage of time-only is low and people won't run into issues.
Eventually we can hopefully move to a proper type for times and avoid that altogether anyway 👍
Description
This PR tackles the following points:
time with time zone
/time without time zone
PG columnsinput type="time"
in the frontend, to support native features and simplifying the codeAddresses
Screenshots
Empty datetime picker
Filled datetime picker
Empty time picker
Filled time picker
Launchcontrol
Fix time-only column issues