Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AssetRipper.Primitives to avoid implying Json 8.0.1 #873

Merged
merged 2 commits into from
May 21, 2024

Conversation

decaprime
Copy link
Contributor

Description

Downgrading AssetRipper.Primitives from 2.1.1 to 2.1.0 to avoid implying System.Text.Json 8.0.1 during build using current BE feed.

Motivation and Context

This recent change to support V Rising included AssetRipper.Primitives 2.1.1 that change implies System.Net.Json 8.0.1 . This causes a NU1605 build warning as error when referencing BE690 nugets. We know that .net 6 is available at runtime, so it is possible to ignore the warning. This change removes the need to ignore that warning.

How Has This Been Tested?

I built BepInEx locally, used it for V Rising server and referenced in two plugins: I built a test plugin and updated a large existing plugin. They built without the warning and functioned in game. To test end to end I built a small test command that echos JSON.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ds5678
Copy link
Contributor

ds5678 commented May 19, 2024

@decaprime decaprime changed the title Downgrade AssetRipper.Primitives patch to avoid implying Json 8.0.1 Upgrade AssetRipper.Primitives to avoid implying Json 8.0.1 May 19, 2024
@decaprime
Copy link
Contributor Author

image
Thanks @ds5678, so I've changed this PR to an upgrade instead @Kasuromi.

@Kasuromi Kasuromi merged commit 3ba398f into BepInEx:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants