Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a DisplayBepInExVersion #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

js6pak
Copy link
Member

@js6pak js6pak commented Feb 15, 2023

Description

Moves the stripping of version build info from ChainloaderLogHelper to a public property

As @ghorsington noted it probably shouldn't be in Paths though, I don't see any existing type good for this, so where should this be?

Motivation and Context

#546 and mods that might want to display the bepinex version

Copy link
Member

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build version is only meant to be used in one place then why not just strip the build number there? Also personally I'd rather keep the build number visible in the console title but that's just me.

Edit: Ah, if other plugins want to use this version then why not add an extension method for stripping the build number? Having a second barely different version property just seems like an overkill to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants