Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NME] Set Block #15090

Merged
merged 5 commits into from May 13, 2024
Merged

[NME] Set Block #15090

merged 5 commits into from May 13, 2024

Conversation

onekit-boss
Copy link
Contributor

@onekit-boss onekit-boss commented May 11, 2024

an emty block, for "a = b"

@onekit-boss onekit-boss changed the title 【NME] Set. Block [NME] Set. Block May 11, 2024
@onekit-boss onekit-boss changed the title [NME] Set. Block [NME] Set Block May 11, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15090/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

@onekit-boss
Copy link
Contributor Author

@deltakosh

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the block is for, though?

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the use cases?

@onekit-boss
Copy link
Contributor Author

for example:
float red = 0.3;
float green = red;
float blue = green;

@onekit-boss
Copy link
Contributor Author

SetBlock_Demo.json

@bjsplat
Copy link
Collaborator

bjsplat commented May 11, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15090/merge/testResults/webgpuplaywright/index.html

@onekit-boss
Copy link
Contributor Author

@deltakosh

@deltakosh
Copy link
Contributor

Well I'm not super convinced but the code change is minimal

@deltakosh deltakosh merged commit d457869 into BabylonJS:master May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants