Add back check to make sure there are active render loops before queuing a new one #15086
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15086/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15086/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15086/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
|
Marking as draft for now until I can prove everything is working well in native. |
|
Can you please add a comment on it to be sure we do not remove it again as it is hard to understand how this could be happening ? |
|
reviewed with @Popov72 and the check is needed no matter the rest of the conditions :-) if we stop during _renderLoop we would continue to queue indefinitely without it. Thanks for the fix !!! |
|
I was going to add comments, but I can add it later. |
|
Added comments in #15095 |
Updating to Babylon.js version 7.0.0 reveals a whole slew of issues when running the validation tests because [#14868](BabylonJS/Babylon.js#14868) broke the render loop stopping behavior when running in native. Native does not implement a way to cancel a requested animation frame. This missing canceling functionality should be added to native someday, but, in the meantime, [#15086](BabylonJS/Babylon.js#15086) will make it behave like it did before. These changes fix potential issues in the code regardless of what happened on the JS side. - Update to latest JsRuntimeHost with lots of fixes. - Call SetRenderResetCallback with null to clear the callback that can cause a crash on shutdown. - Update a few validation tests to not use render count. - Update scripts to use `const`/`let` instead of `var`. - Update validation script to handle some errors better and clean up dead code. - Add unhandled exception handler to Playground app so that validation test will report correct errors and exit correctly. - Change core graphics device implemenation to update bgfx state right before requesting screenshots. This will ensure the screenshot is the right size if the resolution has changed. - Fix TestUtils:WritePNG to return an error when the byte length is an unexpected size instead of silently failing. - Change TestUtils::SetTitle to update the HWND title on a background thread to avoid dead lock with the main thread. - Update dynamic texture clip test to newest version that will fail if the feature is not working.
This is a follow up to #14868. The main reason for adding this check is to make Babylon Native work again, but it also prevents an additional queuing of a new frame if
stopRenderLoopis called during render.