Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual test for two position vertex buffers pointing to same buffer #15074

Merged
merged 1 commit into from May 13, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented May 8, 2024

This test is currently failing in native. Adding to JS to make sure we have the same coverage on both sides.

BabylonJS/BabylonNative#1376 is a potential fix for native, but it causes the buffer to be retained on the CPU. The right thing to do is to fix it like we did for WebGPU.

I will be adding this test to native also.

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bghgary bghgary requested a review from Popov72 May 8, 2024 00:52
@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15074/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 8, 2024

@bghgary bghgary marked this pull request as ready for review May 10, 2024 17:57
@bghgary bghgary enabled auto-merge (squash) May 10, 2024 17:57
@RaananW
Copy link
Member

RaananW commented May 13, 2024

set to auto-merge, i prefer waiting for @Popov72 to approve :-)

@bghgary bghgary merged commit a7641db into BabylonJS:master May 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants