Bump DBus stack take 2 #15685
Open
Bump DBus stack take 2 #15685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use new Variant system
…-tmds-dbus-sourcegenerator
|
You can test this PR using the following package version. |
maxkatz6
added
os-linux
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Bump Tmds.DBus.Protocol and Tmds.DBus.SourceGenerator.
This uses the "official" Variant system instead of the SourceGenerator provided one (which was removed).
Accept the explicit ignoration of the DBus spec and assume collapsed variants.
Dispose DBus objects correctly:
This may need further discussion as it currently uses the Dispatcher.ShutdownFinished event to detect when to dispose those objects (namely
DBusPlatformSettingsand theDBusConnectionitself).Fixes a DBusException when the application closes.
In the future, we might want a more generic approach like making the Locator dispose
IDisposables.Additionally, we run run 2 asynchronous methods synchronously (
DBusConnection.TryInitialize()andDBusPlatformSettings.TryInitialize(). In order to properly fix this, the application startup itself would have to be asynchronous as far as I can see.What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
None
Fixed issues
#15655