-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitignore and git init to templates #1247
base: develop
Are you sure you want to change the base?
Add gitignore and git init to templates #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @anunayasri for your contribution.
The PR looks really good to me. I would like to propose 2 additional changes:
- The content of
.gitignore
is fully loaded with usual Python files to be ignored. However, there is no.vscode
and Vscode related file. Furthermore, there are a lot of ignore lines for packages that are not closely related to Taipy, like "Translations", "Scrapy", "pdm", "Sphinx", ... We may need a discussion to decide what go into this file to make it suitable for a simple template. - In
tests/templates/test_default_template.py
andtests/templates/test_scenario_mgt_template.py
, we do sometimes test for which files and folders are generated after running thetaipy run ...
command. Those tests now should take the new.gitignore
and.git
into account as well.
@trgiangdo Apologies! I was not able to reply to the comment earlier. I made the I will make the changes for the 2nd comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small remark. Otherwise, it is great. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to the official template, you remove a few sections.
I would not remove them to keep the file as standard as possible.
What do you think?
This PR has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this PR, then please add new commit or another comment, otherwise this PR will be closed in 14 days. For more information please refer to the contributing guidelines. |
Fixes #671