Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fullscreen by default in different os with esc to exit #598

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chaosprint
Copy link
Contributor

No description provided.

@chaosprint chaosprint marked this pull request as draft July 22, 2023 07:40
@ten3roberts
Copy link
Contributor

ten3roberts commented Jul 22, 2023

Have you seen gpu/settings.rs? as well as its related AssetKey. This one already stores and persists a window size state. We'd just need a way to write to it from withing the app rather than from the filesystem

@ten3roberts
Copy link
Contributor

Here: https://github.com/AmbientRun/Ambient/blob/main/crates/gpu/src/settings.rs

Takes care of the window size, so a fullscreen option could easily be added to this already existing structure to keep consistent

@chaosprint
Copy link
Contributor Author

Here: https://github.com/AmbientRun/Ambient/blob/main/crates/gpu/src/settings.rs

Takes care of the window size, so a fullscreen option could easily be added to this already existing structure to keep consistent

It's for resolution, right? I do need to change that one as well. Thanks for the info! The change so far is to make the window "Full Screen" with all the control buttons hidden.

@ten3roberts
Copy link
Contributor

Yes, and that would need to be changed since fullscreen (usually) means changing the resolution to the monitor.

I'd suggest making the resolution field an Option<(u32, u32)> or similar, where None is set when going fullscreen meaning "use the monitors resolution"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make game play window fullscreen, hide all the performance (fps, ms rtt, etc) by default.
2 participants