Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 6c for academictwitteR v0.2, don't use positional arguments #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chainsawriot
Copy link

Problem

In the recent academictwitteR update (now on CRAN), the package follows the current httr best practices on storing the bearer token. Although hard-coding bearer token still works in academictwitteR, it is no longer recommended. As this is educational material, we also recommend Twitter to educate the API users to follow these best practices. Thus, users don't hard-code their bearer token in their R scripts or burn in their command history.

Also, the usage of positional arguments should be avoided. It is quick, but it can also be confusing from a pedagogical standpoint.

Solution

Using set_bearer() instead of hard-coding. Using very explicit named arguments.

Result

Potentially higher in pedagogical value.

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants