-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add swiping flag property during swipes (#1682), fix broken resize/etc handler (#1665), resolve itemMargin carousel pagination issue (#1480) #1688
base: master
Are you sure you want to change the base?
Conversation
…minification, add build:js script to master build script, update .gitignore
…v setup if needed after addSlide
If this PR is too much to review & approve... I'd at least like to see 1482f39 implemented (might need to be updated to the current FlexSlider variables to work, but the idea's the same) if that's more bite-sized for a go-ahead approval/merge/release since that does fix the still-active bug of #1480 Also, the workaround of making sure maxItems is supplied isn't readily available for sites using plugins like MetaSlider & others where that setting isn't shown. |
I might have it where
is updated to be
instead actually be changed to
That way, items that don't actually have these values to calculate still use the old/basic setup (I was encountering a browser hang/oddities without that present with multiple sliders on page [some carousels & some not] with some not shown immediately while other are.) |
The reason for adding a swiping property during swipes handled by the touch option is so that swipes can be ignored and not handled as touches/intent to navigate when using the asNav option. Fixes #1682 .
I know you've already got a handle on #1665 but I just thought I'd mention it here because we'd made that fix in parallel in our own repo.
Addresses #1480, where, if you have no maxItems set, the slider.visible calculation could be wrong if a slideMargin value exists.