-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose inferRemoteSize
function
#11098
base: main
Are you sure you want to change the base?
Expose inferRemoteSize
function
#11098
Conversation
🦋 Changeset detectedLatest commit: 38d86cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Refactored it a bit, the only thing missing will be adding better error messages now that this is exposed and stuff. I'll do that later, thank you for contributing! |
Thank you, as always, @Princesseuh! |
Changes
This change exposes the old
inferSize()
, renamed toinferRemoteSize()
per https://discord.com/channels/830184174198718474/1240790957591367701.Testing
No additional testing needed, it was never tested directly.
Docs
Docs migth make sense, tbd.