-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make experimental-dev example app #20327
base: v5/main
Are you sure you want to change the base?
Conversation
I'm wondering if we should rename |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -48 B (0%) Total Size: 2.53 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a bit more discussion on this.
The current "getstarted" should really be called "kitchensink" since it's got almost everything in it
The current "kitchensink" should be called something like "empty" or "clean" or almost anything else.
And then there should be a -ts version of those.
Should it be called Do we need TS versions of both, couldn't we just use the TS versions on their own? I don't think anyone realistically tests against the JS/TS versions? 🤔 at most we could do a |
I'm also wondering, how temporary is this? Do we actually want to add something like this to main or would we be better off keeping a POC branch where we can QA against it until releasing it. |
It all makes sense to me. I guess this kind of error is caused by the React 19 DS compatibility issues you mentioned?
|
yep! |
a86e32a
to
735634b
Compare
735634b
to
a802163
Compare
a802163
to
bad4f63
Compare
590f8ad
to
fef1c82
Compare
fef1c82
to
e02e60c
Compare
I agree with Ben we should have JS and TS versions as we support both and thus should test both. |
theres an RFC internally on this if you want to comment :) I think Ben shared it in engineering, the comments are out of date with what the PR does |
What does it do?
experimental-dev
application set up to work with react-rc & the compilerUSE_EXPERIMENTAL_DEPENDENCIES
flag to the strapi develop/build commands so we can test RCs / Betas of deps we require users to install in their strapi projectsWhy is it needed?
Related issue(s)/PR(s)