add: new layout #296

t-muthuri · 2024-04-17T09:20:31Z

Changes made to src/layouts/layout.js.
Added a new layout called neon to the layout.js file.

Summary by CodeRabbit

New Features
- Introduced a new neon layout with distinct styling and structure.
Style
- Minor indentation adjustments in the samuel layout style function.

vercel · 2024-04-17T09:20:37Z

@t-muthuri is attempting to deploy a commit to the shravan20's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2024-04-17T09:20:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
github-readme-quotes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 6:19pm
github-readme-quotes-returns	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 6:19pm

coderabbitai · 2024-04-17T09:20:39Z

Walkthrough

This update introduces the new neon layout alongside minor formatting adjustments to the samuel layout. These changes aim to enhance design flexibility by adding a fresh layout option and refining existing styling details.

Changes

File Path	Change Summary
`src/layouts/layout.js`	Added `neon` layout with `style` and `structure` functions; minor indentation changes in `samuel` layout's `style` function.
`src/layouts/README.md`	Added information about the new `neon` layout option.

🐇✨ In the land of code where changes play,
A rabbit danced with code today.
Neon lights and tweaks so slight,
Transform the view with code so bright.
Let's explore this digital delight! 🌟👀

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bf8468c and 4768193.

Files selected for processing (1)

src/layouts/README.md (1 hunks)

Additional Context Used

LanguageTool (4)

src/layouts/README.md (4)

Near line 15: Possible spelling mistake found.
Context: ...eadme-quotes-bay.vercel.app/quote) - socrates
![Quote](https://github-readme-q...

Near line 18: Possible spelling mistake found.
Context: ....vercel.app/quote?layout=socrates) - churchill
![Quote](https://github-readme-q...

Near line 21: Possible spelling mistake found.
Context: ...uote?layout=churchill&theme=merko) - samuel
![Quote](https://github-readme-q...

Near line 24: Possible spelling mistake found.
Context: ...-bay.vercel.app/quote?layout=samuel) - zues (Note: This layout does not have...

Additional comments not posted (3)

src/layouts/README.md (3)

Line range hint 10-10: Add a blank line above the heading.

Please add a blank line above the "Layouts" heading to improve readability and adhere to Markdown best practices.

Line range hint 9-9: Surround fenced code blocks with blank lines.

Please ensure that fenced code blocks are surrounded by blank lines to enhance readability and maintain consistency with Markdown formatting standards.

Line range hint 34-34: Remove one of the consecutive blank lines.

Please remove one of the consecutive blank lines to improve readability and maintain consistency with common Markdown practices.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

shravan20

@t-muthuri: There is some issue with build, can you please check that?

t-muthuri · 2024-04-17T10:56:00Z

@t-muthuri: There is some issue with build, can you please check that?

Yes.

t-muthuri · 2024-04-17T11:54:37Z

@shravan20
I have changed a few lines and it looks alright. All checks seem to pass on my end except the authorization one. Kindly let me know if there are any build issues and if possible, where I should check. Thank you.

shravan20 · 2024-04-17T12:04:39Z

@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.

Good work! 🙌🏻

shravan20 · 2024-04-17T12:06:42Z

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once?
Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

t-muthuri · 2024-04-17T17:14:42Z

@t-muthuri: Can you update the same as part of the document? Add sample link for reference as well for preview.

Good work! 🙌🏻

Yes. Thank you.

t-muthuri · 2024-04-17T17:46:14Z

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this
unique deployment URL
as you are not a member of the team. You can view the latest version of this branch by requesting access to the
up-to-date deployment URL
."

How do I go about it?

shravan20 · 2024-04-17T20:22:45Z

Attaching the image for your reference @t-muthuri

shravan20 · 2024-04-17T20:23:50Z

Note: Build issue is resolved after accepting the deployment authorization

There is a design bug, can you check this once? Preview it : https://github-readme-quotes-9hqums9tr-shravan20s-projects.vercel.app/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

We should return only the card instead seems like we are creating a div outside the card and returning that div.

I don't seem to be able to preview it. The message is "Team Access Required. You cannot access this
unique deployment URL
as you are not a member of the team. You can view the latest version of this branch by requesting access to the
up-to-date deployment URL
."

How do I go about it?

Check it in the local system:

https://localhost:3000/quote?theme=default&animation=default&layout=neon&font=default&fontColor=white&bgColor=black

…s into add/layout

coderabbitai

Actionable comments posted: 1

Actionable comments outside the diff hunks (3)

src/layouts/README.md (3)
Line range hint 35-35: Remove one of the consecutive blank lines.
-
This will improve the readability and maintain consistency with common Markdown practices.

Line range hint 10-10: Ensure headings are surrounded by blank lines for better readability.
+
This will improve the structure and readability of the document.

Line range hint 9-9: Ensure fenced code blocks are surrounded by blank lines.
+
This will enhance the readability and formatting of the document.

src/layouts/README.md

t-muthuri · 2024-04-18T13:38:40Z

@shravan20
I have solved the design bug that was there. The div is now rendering as expected. I have also updated the README.md file to include the new layout.

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-18T13:38:51Z

src/layouts/README.md

+- neon <br>
+  ![Quote](https://github-readme-quotes-bay.vercel.app/quote?layout=neon)


Broken image link for the "neon" layout.

Please verify the URL for the image associated with the "neon" layout, as it appears to be broken. This needs to be corrected to ensure the layout is properly represented in the documentation.

shravan20 · 2024-04-18T18:21:12Z

@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized.
Added a sample for preview

t-muthuri · 2024-04-18T19:09:09Z

@t-muthuri: Author name is completely getting skipped, it isn't getting auto-sized. Added a sample for preview

@shravan20
I cannot tell what the problem is from my end, because when run locally, it renders the div well. See the images attached below.

shravan20 · 2024-05-01T12:05:14Z

@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.

Thank you!

t-muthuri · 2024-05-01T22:04:00Z

@t-muthuri: Kindly reopen this, I would like to take a look at it myself & see if its issue from the deployment end.

Thank you!

@shravan20 Hello, I have reopened the PR. Thank you.

add: new layout

0f7e237

vercel bot deployed to Preview – github-readme-quotes-returns April 17, 2024 09:21 View deployment

shravan20 requested changes Apr 17, 2024

View reviewed changes

add: new layout neon

03c57f2

vercel bot deployed to Preview – github-readme-quotes-returns April 17, 2024 11:48 View deployment

fix: missing fonts

0e717d6

vercel bot deployed to Preview – github-readme-quotes-returns April 17, 2024 12:00 View deployment

vercel bot deployed to Preview – github-readme-quotes April 17, 2024 12:04 View deployment

Merge branch 'main' into add/layout

3914d00

vercel bot deployed to Preview – github-readme-quotes-returns April 17, 2024 12:59 View deployment

t-muthuri closed this Apr 17, 2024

t-muthuri reopened this Apr 17, 2024

t-muthuri added 3 commits April 18, 2024 16:17

fix: design of div

38372e9

fix: div design

d13091e

Merge branch 'add/layout' of github.com:t-muthuri/github-readme-quote…

bf8468c

…s into add/layout

vercel bot deployed to Preview – github-readme-quotes-returns April 18, 2024 13:32 View deployment

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

src/layouts/README.md Show resolved Hide resolved

fix: remove one blank line

4768193

vercel bot deployed to Preview – github-readme-quotes-returns April 18, 2024 13:37 View deployment

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

vercel bot deployed to Preview – github-readme-quotes April 18, 2024 18:19 View deployment

t-muthuri closed this Apr 29, 2024

t-muthuri reopened this May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add: new layout #296

add: new layout #296

t-muthuri commented Apr 17, 2024 •

edited by coderabbitai bot

vercel bot commented Apr 17, 2024

vercel bot commented Apr 17, 2024 •

edited

coderabbitai bot commented Apr 17, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

shravan20 left a comment

t-muthuri commented Apr 17, 2024

t-muthuri commented Apr 17, 2024 •

edited

shravan20 commented Apr 17, 2024

shravan20 commented Apr 17, 2024 •

edited

t-muthuri commented Apr 17, 2024

t-muthuri commented Apr 17, 2024

shravan20 commented Apr 17, 2024

shravan20 commented Apr 17, 2024

coderabbitai bot left a comment

t-muthuri commented Apr 18, 2024

coderabbitai bot left a comment

coderabbitai bot Apr 18, 2024

shravan20 commented Apr 18, 2024

t-muthuri commented Apr 18, 2024

shravan20 commented May 1, 2024

t-muthuri commented May 1, 2024

		- neon <br>
		![Quote](https://github-readme-quotes-bay.vercel.app/quote?layout=neon)

add: new layout #296

Are you sure you want to change the base?

add: new layout #296

Conversation

t-muthuri commented Apr 17, 2024 • edited by coderabbitai bot

Summary by CodeRabbit

vercel bot commented Apr 17, 2024

vercel bot commented Apr 17, 2024 • edited

coderabbitai bot commented Apr 17, 2024 • edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

shravan20 left a comment

Choose a reason for hiding this comment

t-muthuri commented Apr 17, 2024

t-muthuri commented Apr 17, 2024 • edited

shravan20 commented Apr 17, 2024

shravan20 commented Apr 17, 2024 • edited

t-muthuri commented Apr 17, 2024

t-muthuri commented Apr 17, 2024

shravan20 commented Apr 17, 2024

shravan20 commented Apr 17, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

t-muthuri commented Apr 18, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 18, 2024

Choose a reason for hiding this comment

shravan20 commented Apr 18, 2024

t-muthuri commented Apr 18, 2024

shravan20 commented May 1, 2024

t-muthuri commented May 1, 2024

t-muthuri commented Apr 17, 2024 •

edited by coderabbitai bot

vercel bot commented Apr 17, 2024 •

edited

coderabbitai bot commented Apr 17, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

t-muthuri commented Apr 17, 2024 •

edited

shravan20 commented Apr 17, 2024 •

edited