Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically list test files #13220

Merged

Conversation

dev-jonghoonpark
Copy link
Contributor

Related issue
#13219

Motivation
Currently we have to manually update the all_tests variable when introducing new test files.

Modification
I have modified it to list test files dynamically, but instead of modifying it to add all test files, I have modified it to only add only test files from the following 4 paths

  • unit
  • unit/type
  • unit/cluster
  • integration

so that it doesn't deviate too much from what we already do

Result

Additional information

  • removed list-common.tcl file and added generate_largevalue_test_array proc in util.tcl. because list-common.tcl is not a test file
  • There is an order dependency. So I added a code to the "Is a ziplist encoded Hash promoted on big payload?" test that resets hash-max-listpack-value to the default (64).

Signed-off-by: jonghoonpark <dev@jonghoonpark.com>
@sundb
Copy link
Collaborator

sundb commented Apr 18, 2024

this PR is safe for merge.

@sundb sundb added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label May 7, 2024
@sundb
Copy link
Collaborator

sundb commented May 30, 2024

@dev-jonghoonpark i fixed some failure due to the changes of unstable, please have a look if you have time, thanks.

@sundb sundb merged commit 5a3534f into redis:unstable May 30, 2024
13 checks passed
@sundb sundb linked an issue May 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[NEW] dynamically list test files
3 participants