-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for all hash field expiration commands #2742
base: v5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, but:
- I've made some changes, please review them..
- Seems like
HGETF
andHSETF
are missing
change look fine |
transformArguments(key: RedisArgument, fields: RedisVariadicArgument) { | ||
return pushVariadicArgument(['HPERSIST', key], fields); | ||
}, | ||
transformReply: undefined as unknown as () => ArrayReply<NumberReply> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoule we create an "enum" for the reply just like in HPEXIRE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an enum
Description
adds the has field expiration commands - for testing purposes, need a docker container that has it in it.
Checklist
npm test
pass with this change (including linting)?