Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/17109] Don't show the attach signature option if the user doesn't have permission #6617

Merged
merged 1 commit into from
May 23, 2024

Conversation

battye
Copy link
Member

@battye battye commented May 17, 2024

This fixes a bug on the posting page and on the UCP posting preferences page, the attach signature option was being displayed even if the user had the "Can use signature" option set to "never" in their user permissions.

PHPBB3-17109

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-17109

Don't show the attach signature option if the
user doesn't have permission or if the signature
feature is disabled for the board.

PHPBB3-17109
phpBB/posting.php Show resolved Hide resolved
@marc1706 marc1706 merged commit 477f5d9 into phpbb:3.3.x May 23, 2024
45 checks passed
@battye battye deleted the ticket/17109 branch May 27, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants