[ticket/17317] Change button text for pm recipient to increase readability #6616
Conversation
|
I've added a second commit because I accidentally changed Button need left and right padding, not top and bottom. |
|
I've updated the change to what @iMattPro has suggested in the ticket because I agree that it's a better change compared to simply having a default button with the word remove in it. |
|
Latest commit addresses both issues in review by @iMattPro. I'd say it's time to merge and have a brew 🙂 |
…ility PHPBB3-17317
Updated the button to a small red X using Font Awesome rather than using the default phpBB button with text which adds a better visual distinction in the interface between the username and action. Credit to @iMattPro for the suggestion in the ticket comments. PHPBB3-17317
|
The commit hook check found an issue again. You had for example: However, the commit message hook requires there to be either a comment or an empty line before the PHPBB3-17317: I've changed that now :) |
|
Thanks, sorry about that. I've done that on a couple of commits but now I know for next time! |
|
@danieltj27 On a side note, I have also adapted the changes in master. However, the only difference is that the icon does use a normal cursor for the button now. Might want to check this out and maybe adapt for it accordingly in master. |
I've updated the text on the submit button used to remove recipients from a PM that is currently being composed. It used to just be a small
xthat was hard (for me and of course others) to see.I've updated it to say
Removewhich is already an existing language string so no new translations are required for this change. I also added a 2px padding so the text isn't flush to the edges of the button.It makes it more readable and actually looks styled as opposed to looking like an element that was forgotten about. I think this makes the interface much better to use.
PHPBB3-17317
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB3-17317