Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/17315] add template events to acp_groups #6613

Merged
merged 2 commits into from
May 31, 2024

Conversation

danieltj27
Copy link
Contributor

@danieltj27 danieltj27 commented May 16, 2024

Re-submitting my PR after I made a mistake in the last one #6612.

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB3-17315

@danieltj27
Copy link
Contributor Author

danieltj27 commented May 16, 2024

The testing failed 😭

phpbb_event_md_exporter_test test_crawl_template_file with data set #83 History | < 1 sec
phpbb_event_md_exporter_test::test_crawl_template_file with data set #83 ('adm', 'adm/style/acp_groups.html') LogicException: File 'adm/style/acp_groups.html' contains additional events: 'acp_groups_add_user_form_before', 'acp_groups_add_user_form_during', 'acp_groups_add_user_form_after'  /data/phpBB/phpbb/event/md_exporter.php:640 /data/tests/event/md_exporter_test.php:150 phpvfscomposer:///data/phpBB/vendor/phpunit/phpunit/phpunit:60

@marc1706
Copy link
Member

marc1706 commented May 16, 2024

I have slightly adjusted the naming of the proposed events to be more in line with our current events. In addition to that, I have also added the events to events.md. This is what the test failure complained about. :)

edit: I have also modified your commit message to fit our commit message format: https://area51.phpbb.com/docs/dev/3.3.x/development/git.html#commit-messages

@danieltj27
Copy link
Contributor Author

Thank you for sorting that out. I know for next time 🙂

@marc1706 marc1706 merged commit 276502c into phpbb:3.3.x May 31, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants