[ticket/17175] Fix topic title in the breadcrumbs when emailing a topic #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the test failure was a GitHub problem rather than a code problem: "Windows - PHP 8.2 - postgres - unit - GitHub Actions has encountered an internal error when running your job." If the test can please be re-run I think it'll pass. |
marc1706
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB3-17175
This fixes a bug whereby the wrong topic title would show in the breadcrumbs when emailing a topic. (The cause was that the SQL query was missing
t.topic_id = ' . (int) $topic_id)Checklist:
Tracker ticket:
https://tracker.phpbb.com/projects/PHPBB3/issues/PHPBB3-17175
Screenshot:
(Previously, no matter what the topic id was it would always show the name of the first topic posted in that forum. Now, the breadcrumb will reflect the correct topic title associated with the topic id.)