fix(ui): blocks browser save dialog from opening when hotkey used with no changes #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JessChowdhury
force-pushed
the
chore/save-hotkey
branch
from
81ce588
to
1afb138
Compare
JessChowdhury
force-pushed
the
chore/save-hotkey
branch
from
d929a08
to
1afb138
Compare
JessChowdhury
requested review from
jacobsfletch
and removed request for
denolfe and
AlessioGr
JessChowdhury
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue #214 (3.0).
Using the
cmd+shotkey in the Edit Document view was opening the browser save dialogue when no changes had been made.This change triggers a toast info banner with
No changes to saveand adds translated string for other languages.PR for 3.0 is here.
Type of change
Checklist: