Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] sale_management: do not reset lines on template removal #166082

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 17, 2024

Keep logic as it was before the onchange -> computes refactoring, so that (default) products added to an order before the onchange execution are not dropped.

Forward-Port-Of: #166010

@robodoo
Copy link
Contributor

robodoo commented May 17, 2024

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 17, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label May 18, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented May 18, 2024

@Feyensv ci/runbot failed on this forward-port PR

@Feyensv
Copy link
Contributor

Feyensv commented May 20, 2024

@fw-bot r+

@robodoo
Copy link
Contributor

robodoo commented May 20, 2024

@Feyensv you may want to rebuild or fix this PR as it has failed CI.

Keep logic as it was before the onchange -> computes refactoring,
so that (default) products added to an order before the onchange
execution are not dropped.

X-original-commit: 2a13e49
@Feyensv Feyensv force-pushed the master-16.0-sale-no-template-no-reset-vfe-IVdn-fw branch from a633c8e to eaf604e Compare May 21, 2024 11:59
@Feyensv
Copy link
Contributor

Feyensv commented May 21, 2024

@robodoo r+

@fw-bot
Copy link
Contributor Author

fw-bot commented May 21, 2024

@Feyensv this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

robodoo pushed a commit that referenced this pull request May 21, 2024
Keep logic as it was before the onchange -> computes refactoring,
so that (default) products added to an order before the onchange
execution are not dropped.

closes #166082

X-original-commit: 2a13e49
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this May 21, 2024
@robodoo robodoo added the 17.3 label May 21, 2024
zel-odoo pushed a commit to odoo-dev/odoo that referenced this pull request May 24, 2024
Keep logic as it was before the onchange -> computes refactoring,
so that (default) products added to an order before the onchange
execution are not dropped.

closes odoo#166082

X-original-commit: 2a13e49
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants