Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OpenAI Conersational Model #9227

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

MinuraPunchihewa
Copy link
Contributor

Description

This PR achieves the following,

  1. Fixes the conversational model by fixing the issue mentioned below.
  2. Removes some code centered around the assistant_column that seems redundant. As shown here, this column no longer seems to be in the expected list of arguments. @paxcema Let me know what your thoughts are on this.

Fixes #9226

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

conversational mode:
image

conversational-full mode:
image

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

Copy link
Member

@paxcema paxcema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think changes around invalid arguments make sense.

@ZoranPandovski ZoranPandovski merged commit 2624170 into main May 21, 2024
14 checks passed
@ZoranPandovski ZoranPandovski deleted the bugfix/openai_conv_mode_fixes branch May 21, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenAI Converational Mode is Broken
3 participants