OpenAI Integration Improvements #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StpMax I cannot seem to run the fine-tuning test reliably; running into a bunch of errors. So, i've just commented it out for now. |
|
@ZoranPandovski I believe this is ready for review now. |
ZoranPandovski
requested changes
May 29, 2024
There was a problem hiding this comment.
Thanks. Before we merge let's remove the openai handler from flake ignore file https://github.com/mindsdb/mindsdb/blob/main/.flake8#L144C1-L144C49, also we can remove the commented test for now
Done. |
ZoranPandovski
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the OpenAI handler in order to make it Enterprise-ready.
Type of change
Verification Process
To ensure the changes are working as expected:
Test Location:
tests/unit/ml_handlers/test_openai.pyfor unit tests andmindsdb/integrations/handlers/openai_handler/tests/test_openai_handler.pyfor integration tests.Verification Steps: Run the above test modules (for integration tests, an OpenAI API key will be required).
My code follows the style guidelines(PEP 8) of MindsDB.
I have appropriately commented on my code, especially in complex areas.
Necessary documentation updates are either made or tracked in issues.
Relevant unit and integration tests are updated or added.