Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: mypy coverage enhancement #6250

Merged
merged 16 commits into from
May 31, 2024

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented May 14, 2024

Motivation and Context

extend mypy coverage for prompt_templates, template_engine and some other smaller folders.

still todo: connectors, memory and planner folders.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner May 14, 2024 12:27
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 14, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 14, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py933859%124, 131–140, 178–186, 257–293
semantic_kernel/core_plugins
   conversation_summary_plugin.py16850%37–38, 64–73
   web_search_engine_plugin.py9278%28, 38
semantic_kernel/core_plugins/sessions_python_tool
   sessions_python_plugin.py1021486%59–61, 81, 84, 89–95, 134, 185, 189
semantic_kernel/functions
   kernel_function_from_prompt.py161796%159–160, 181, 201, 226, 247, 327
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py1154363%132–222, 257–262
semantic_kernel/planners/sequential_planner
   sequential_planner.py64691%69, 73, 107, 123, 132–133
semantic_kernel/template_engine/blocks
   named_arg_block.py43198%98
TOTAL607678087% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1402 1 💤 0 ❌ 0 🔥 20.352s ⏱️

@eavanvalkenburg eavanvalkenburg changed the title Python: mypy coverage for prompt templates Python: mypy coverage enhancement May 31, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 31, 2024
Merged via the queue into microsoft:main with commit ba9af0e May 31, 2024
23 checks passed
@eavanvalkenburg eavanvalkenburg deleted the mypy_prompt_template branch May 31, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants