Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: (Astra DB) Explicit projection when reading from Astra DB #6246

Merged
merged 15 commits into from
May 28, 2024

Conversation

hemidactylus
Copy link
Contributor

Motivation and Context

In view of upcoming changes in the Astra DB Data API, this PR explicitly sets a projection every time a find command is executed, in order to ensure all necessary fields of the document are returned by the API.

Description

Added an else branch in the astra_client.py to ensure there always is a "projection" field in the body for the find command. This ensures that $vector is returned by the API even in case of Astra DB rolling out an exclude-it-by-default policy in the future.

Contribution Checklist

@hemidactylus hemidactylus requested a review from a team as a code owner May 14, 2024 09:23
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels May 14, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 28, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL609888186% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1374 1 💤 0 ❌ 0 🔥 17.006s ⏱️

@moonbox3 moonbox3 enabled auto-merge May 28, 2024 19:34
@moonbox3 moonbox3 added this pull request to the merge queue May 28, 2024
Merged via the queue into microsoft:main with commit f7f5abc May 28, 2024
23 checks passed
@hemidactylus hemidactylus deleted the SL-astra-db-explicit-projection branch May 28, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants