Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFServing otlp support improvement #3305

Merged
merged 1 commit into from
May 22, 2024

Conversation

wxpjimmy
Copy link
Contributor

…support otlp log exporter

Description

  • change metrics dimension default value from none to "", this is to avoid otlp metrics encode failure
  • change both http and grpc otlp collector
  • support otlp and app insight log exporter

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@wxpjimmy wxpjimmy requested a review from a team as a code owner May 17, 2024 10:25
Copy link

promptflow SDK CLI Azure E2E Test Result xiaopwan/pfserving_otlp_support_improvement

  4 files    4 suites   4m 8s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit 543556a.

Copy link

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 543556a.

Copy link

SDK CLI Global Config Test Result xiaopwan/pfserving_otlp_support_improvement

6 tests   6 ✅  1m 12s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 543556a.

Copy link

Executor Unit Test Result xiaopwan/pfserving_otlp_support_improvement

796 tests   796 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 543556a.

Copy link

Executor E2E Test Result xiaopwan/pfserving_otlp_support_improvement

246 tests   240 ✅  5m 2s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit 543556a.

Copy link

github-actions bot commented May 17, 2024

SDK CLI Test Result xiaopwan/pfserving_otlp_support_improvement

    4 files      4 suites   1h 5m 21s ⏱️
  783 tests   740 ✅  43 💤 0 ❌
3 132 runs  2 960 ✅ 172 💤 0 ❌

Results for commit 543556a.

♻️ This comment has been updated with latest results.

@wangchao1230 wangchao1230 merged commit fb0b442 into main May 22, 2024
51 checks passed
@wangchao1230 wangchao1230 deleted the xiaopwan/pfserving_otlp_support_improvement branch May 22, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants