Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we avoid binding redirects since Locator controls binding? #83

Open
rainersigwald opened this issue Jan 30, 2020 · 1 comment
Open

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Jan 30, 2020

Currently Locator pushes MSBuild binding redirects into the app.config of the app that references it.

MSBuild requires assembly unification because a new version of MSBuild must be able to run tasks compiled against an older MSBuild, so we must unify to the engine's version of ITask and ITaskItem and so on.

However, MSBuildLocator is in charge of loading MSBuild assemblies, and can do some unification itself. Is that sufficient to drop the need to have app.config binding redirects for client applications?

If this worked, we could more freely rev MSBuild's assembly version, since we'd be binding by location rather than version.

@rainersigwald
Copy link
Member Author

@AndyGerlicher, was talking about this with @nguerrera and we both have a vague recollection that this wouldn't be enough, but no idea why. Do you remember anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant