Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Breaking/Planned changes for MSBuild.Locator v2.0 #282

Open
YuliiaKovalova opened this issue Feb 26, 2024 · 1 comment
Open

List of Breaking/Planned changes for MSBuild.Locator v2.0 #282

YuliiaKovalova opened this issue Feb 26, 2024 · 1 comment
Assignees

Comments

@YuliiaKovalova
Copy link
Contributor

YuliiaKovalova commented Feb 26, 2024

  1. Remove extra property AllowQueryAllRuntimeVersions. AllowAllRuntimeVersions from VisualStudioInstanceQueryOptions.cs means the same, but can't clean up immediately due to backward compatibility.
  2. There is a request to add a warning message about the possible compatibility issues - sometimes MSBuild that is being loaded is just too old to have modern things. Add warning message about the used MSBuild version #272 & Identify architecture of found MSBuild #130
    Change API to...
class MSBuildLocationResult
{
  public bool IsCompatibleWithCurrentRuntime;
  public MSBuildLocatorWarning[] Warnings;
  public string RootPath;
  public MSBuildDiscoveryType Context;

  public Version Version;
  public Architecture Architecture; 


  public void Register() {}
}
  1. Project targeting .NET 6 cannot use Microsoft.Build 17.4.0 nuget package. dotnet/msbuild#8166 - compatibility warning
  2. Add some guardrails to MSBuild Locator #254 - can be also a part of compatibility warning section
  3. Can we avoid binding redirects since Locator controls binding? #83 - find the way to implement this
  4. Add handling for the case described here: [Bug]: Project object can no longer be created if the change wave 17.10 is in use. dotnet/msbuild#9869 (comment)
@rainersigwald
Copy link
Member

After reading what you wrote above, I added a Version field to the result, which may actually supersede some of the warning stuff.

@YuliiaKovalova YuliiaKovalova changed the title List of Breaking changes for MSBuild.Locator v 2.0 List of Breaking changes for MSBuild.Locator v2.0 Feb 28, 2024
@YuliiaKovalova YuliiaKovalova changed the title List of Breaking changes for MSBuild.Locator v2.0 List of Breaking/Planned changes for MSBuild.Locator v2.0 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants