Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calendar layout to Global Issues page #4511

Open
wants to merge 3 commits into
base: preview
Choose a base branch
from

Conversation

vinhloc30796
Copy link

@vinhloc30796 vinhloc30796 commented May 18, 2024

Why

closes #4131 (part of)

What

  • Split out renderQuickActions for BaseCalendarRoot
  • Update headers/global-issues.tsx to add LayoutSelection
  • Add calendar-view.tsx
  • Add CalendarView to issue-layouts/roots/all-issue-layout-root.tsx
  • Add types to web/constants/issue.ts
  • Add issue grouping to issue.store.ts
  • Minor updates to filter.store.ts

Questions / TODOs

  • This PR doesn't allow changing Calendar layout (month vs week, show vs hide weekends) yet, but I'm not sure what I'm missing
  • I'm not sure if I'm updating displayFilters = this.computedDisplayFilters(_filters?.display_filters); correctly in filter.store.ts
  • I'm not sure if issue-layouts/calendar/calendar-view.tsx is the idiomatic/proper way & proper place to do it

@CLAassistant
Copy link

CLAassistant commented May 18, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Adding "Gantt Chart", "Kanban" & "Calendar" Layouts to "All Issues/Global View"
2 participants