-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Fixed a bug around season endpoints #527
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
============================================
+ Coverage 57.76% 57.84% +0.08%
Complexity 1352 1352
============================================
Files 339 339
Lines 5209 5212 +3
============================================
+ Hits 3009 3015 +6
+ Misses 2200 2197 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pushrbx Sorry for the late review. Overall functionality LGTM. There's one issue with flags which I've pointed out.
- added a new parameter: "continuing" - continuing items from previous seasons are now excluded by default - should fix #521
24ce30c
to
dc78949
Compare
There is another bug in the test system, which makes the tests flaky. 😫 |
I've added some seeding based on the job id if the test is being ran in a github action runner. Also I've tweaked the factories:
|
Fixes #521
continuing
-- e.g./v4/seasons/2024/winter?continuing