Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fuction composition #2954

Merged
merged 19 commits into from
Jun 1, 2024

Conversation

Adelechka
Copy link
Contributor

Function Composition pattern (#2897)

Related: #2897
Pull request description

sample java code with javadoc
test code
UML diagram
README.md file

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem to contain also Virtual Proxy. Please isolate them from this PR - this should be only about Function Composition.

@Adelechka
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions 1 Security Hotspot 75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

problems found in a file that is not in my pull request

@Adelechka Adelechka requested a review from iluwatar May 14, 2024 17:33
@@ -0,0 +1,113 @@
---
title: Function Composer
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Function Composer
title: Function Composition

- Java
---

## Name / classification
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 6 to 8
- Functional Programming
- Composition
- Java
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 47 to 52
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.20</version> <!-- Use the latest version -->
<scope>provided</scope>
</dependency>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, comes from the parent

@Adelechka Adelechka requested a review from iluwatar May 28, 2024 19:33
Copy link

sonarcloud bot commented May 28, 2024

@iluwatar iluwatar merged commit 684b2e2 into iluwatar:master Jun 1, 2024
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented Jun 1, 2024

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Adelechka for code

Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Adelechka already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants