Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DefaultFileSystemAccess.snapshot ignoring filter #29206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathjeff
Copy link
Contributor

Fixes: #29205

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

Fixes: gradle#29205
Signed-off-by: Jeff Gaston <gastoj3@gmail.com>
@mathjeff mathjeff requested review from a team as code owners May 17, 2024 22:20
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels May 17, 2024
@ljacomet ljacomet added in:virtual-file-system VFS, file system watching, snapshots 👋 team-triage Issues that need to be triaged by a specific team and removed to-triage labels May 21, 2024
@mlopatkin mlopatkin added this to the 8.9 RC1 milestone May 21, 2024
@lptr lptr self-assigned this May 22, 2024
@lptr lptr removed the 👋 team-triage Issues that need to be triaged by a specific team label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:virtual-file-system VFS, file system watching, snapshots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultFileSystemAccess.snapshot sometimes ignoring filter
5 participants