Reimplement reporting error and warning count when a compilation error happens #29183

hegyibalint · 2024-05-16T13:03:14Z

When the new problem reporting framework was introduced, we didn't yet implement the error counters.

E.g., the following output from javac has a count at the end (note on the bottom the counters)

Test.java:4: warning: [cast] redundant cast to int
        int value = (int)1;
                    ^
Test.java:5: error: int cannot be dereferenced
        return value.toString();
                    ^
1 error
1 warning

This PR adds these counters back.

donat

Looks good. I have only a few questions for my own education and some naming/documentation-related requests.

.../src/integTest/groovy/org/gradle/api/tasks/compile/JavaCompileProblemsIntegrationTest.groovy

...ge-java/src/main/java/org/gradle/api/internal/tasks/compile/DiagnosticToProblemListener.java

donat · 2024-05-22T14:52:08Z

...ge-java/src/main/java/org/gradle/api/internal/tasks/compile/DiagnosticToProblemListener.java

+    /**
+     * This method is based on {JavaCompiler#printCount()}
+     */


❌ The javadoc should state the following:

functionality: this method prints the number of warnings / errors to the standard output

intent: when there's no diagnostic listener attached to the compiler object, the number of warnings/errors are part of the putput. Since we have a listener attached, the output changed. Calling this method makes restores compatiblity with the original output

source: the method implementation is based on {JavaCompiler#printCount()}.

Added further documentation

donat · 2024-05-22T14:53:36Z

...s/jvm/language-java/src/main/java/org/gradle/api/internal/tasks/compile/JdkJavaCompiler.java

@@ -63,6 +63,7 @@ public WorkResult execute(JavaCompileSpec spec) {
        ApiCompilerResult result = new ApiCompilerResult();
        JavaCompiler.CompilationTask task = createCompileTask(spec, result);
        boolean success = task.call();
+        diagnosticToProblemListener.reportDiagnosticCounts();


❓ Will we hit this code path when we do joint Java-Groovy compilation?

Added a new integration test verifying this

…porting works

...y/src/integTest/groovy/org/gradle/groovy/compile/GroovyCompileProblemsIntegrationTest.groovy

...ge-java/src/main/java/org/gradle/api/internal/tasks/compile/DiagnosticToProblemListener.java

…porting works

…t-error-count' into bhegyi/problems/java-compile/emit-error-count # Conflicts: # platforms/jvm/language-groovy/src/integTest/groovy/org/gradle/groovy/compile/GroovyCompileProblemsIntegrationTest.groovy # platforms/jvm/language-java/src/integTest/groovy/org/gradle/api/tasks/compile/JavaCompileProblemsIntegrationTest.groovy # platforms/jvm/language-java/src/main/java/org/gradle/api/internal/tasks/compile/DiagnosticToProblemListener.java

We don't need the compiler context here, so we can freely make a new object.

bot-gradle · 2024-06-04T12:26:15Z

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

bot-gradle · 2024-06-04T13:41:48Z

The merge queue build has failed. Click here to see all failures.

donat · 2024-06-04T14:34:54Z

@bot-gradle merge

bot-gradle · 2024-06-04T14:35:10Z

Sorry, we can't process your request because of the following error:

Pull request is already in the queue

bot-gradle · 2024-06-05T07:16:28Z

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

hegyibalint · 2024-06-05T07:16:35Z

Failed due to flaky tests

bot-gradle · 2024-06-05T08:36:22Z

The merge queue build has failed. Click here to see all failures.

…it-error-count

hegyibalint · 2024-06-05T09:56:59Z

Fixed the snippet, where I've reintroduced the error count.

hegyibalint · 2024-06-05T09:57:28Z

Currently I'm running a snippet test to pre-test the merge.

bot-gradle · 2024-06-05T10:46:50Z

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

Reimplement error and warning count reporting

29f4372

hegyibalint requested a review from a team as a code owner May 16, 2024 13:03

hegyibalint requested a review from big-guy May 16, 2024 13:03

github-actions bot assigned hegyibalint May 16, 2024

hegyibalint changed the title ~~bhegyi/problems/java-compile/emit-error-count~~ Reimplement reporting error and warning count when a compilation error happens May 16, 2024

gitstream-cm bot added the 1 min review label May 16, 2024

hegyibalint requested a review from a team May 16, 2024 13:11

hegyibalint added a:regression This used to work in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures labels May 16, 2024

hegyibalint added this to the 8.9 RC1 milestone May 16, 2024

hegyibalint linked an issue May 16, 2024 that may be closed by this pull request

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint removed a link to an issue May 16, 2024

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint linked an issue May 17, 2024 that may be closed by this pull request

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint removed a link to an issue May 17, 2024

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint linked an issue May 17, 2024 that may be closed by this pull request

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint removed a link to an issue May 17, 2024

Problem-reporting capable compilation doesn't emit error count #28930

Closed

hegyibalint linked an issue May 17, 2024 that may be closed by this pull request

Problem-reporting capable compilation doesn't emit error count #28930

Closed

donat requested changes May 22, 2024

View reviewed changes

tresat removed the 1 min review label May 24, 2024

hegyibalint added 3 commits May 27, 2024 16:06

Rename methods, and add further documentation

20a0203

Add groovy integration test checking if the join compilation error re…

23f69ad

…porting works

Add extra documentation

387f400

hegyibalint requested a review from donat May 28, 2024 07:01

donat requested changes May 29, 2024

View reviewed changes

hegyibalint and others added 5 commits May 30, 2024 14:04

Reimplement error and warning count reporting

025a147

Rename methods, and add further documentation

8dbe478

Add groovy integration test checking if the join compilation error re…

c542bb7

…porting works

Add extra documentation

e015001

Resolve review items

193c3f7

donat force-pushed the bhegyi/problems/java-compile/emit-error-count branch from 387f400 to 193c3f7 Compare May 30, 2024 12:15

donat and others added 2 commits May 30, 2024 15:58

Fix failing test

b81b983

Add new test covering error count reports

8189239

hegyibalint requested a review from donat June 3, 2024 14:18

hegyibalint added 3 commits June 3, 2024 15:20

Use a fresh context when the diagnostic counts are printed.

a909456

We don't need the compiler context here, so we can freely make a new object.

Make a new class generator

4bed411

donat approved these changes Jun 4, 2024

View reviewed changes

hegyibalint added this pull request to the merge queue Jun 4, 2024

gradle deleted a comment from donat Jun 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024

hegyibalint added this pull request to the merge queue Jun 5, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024

hegyibalint added 2 commits June 5, 2024 10:21

Merge branch 'refs/heads/master' into bhegyi/problems/java-compile/em…

0ecf490

…it-error-count

Fix test output, reintroducing the error count

0ef4b22

hegyibalint requested a review from a team as a code owner June 5, 2024 09:29

hegyibalint added this pull request to the merge queue Jun 5, 2024

Merged via the queue into master with commit dae448e Jun 5, 2024
30 checks passed

hegyibalint deleted the bhegyi/problems/java-compile/emit-error-count branch June 5, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reimplement reporting error and warning count when a compilation error happens #29183

Reimplement reporting error and warning count when a compilation error happens #29183

hegyibalint commented May 16, 2024 •

edited

donat left a comment

donat May 22, 2024

hegyibalint May 27, 2024

donat May 22, 2024

hegyibalint May 27, 2024

bot-gradle commented Jun 4, 2024

bot-gradle commented Jun 4, 2024

donat commented Jun 4, 2024

bot-gradle commented Jun 4, 2024

bot-gradle commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

bot-gradle commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

bot-gradle commented Jun 5, 2024

Reimplement reporting error and warning count when a compilation error happens #29183

Reimplement reporting error and warning count when a compilation error happens #29183

Conversation

hegyibalint commented May 16, 2024 • edited

donat left a comment

Choose a reason for hiding this comment

donat May 22, 2024

Choose a reason for hiding this comment

hegyibalint May 27, 2024

Choose a reason for hiding this comment

donat May 22, 2024

Choose a reason for hiding this comment

hegyibalint May 27, 2024

Choose a reason for hiding this comment

bot-gradle commented Jun 4, 2024

bot-gradle commented Jun 4, 2024

donat commented Jun 4, 2024

bot-gradle commented Jun 4, 2024

bot-gradle commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

bot-gradle commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

hegyibalint commented Jun 5, 2024

bot-gradle commented Jun 5, 2024

hegyibalint commented May 16, 2024 •

edited