-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no lock parameter for Postgres #1030
base: master
Are you sure you want to change the base?
Add no lock parameter for Postgres #1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ray-Barker thanks for the PR!
Could you address my comments and rebase to re-run tests?
@@ -53,6 +53,7 @@ type Config struct { | |||
migrationsTableName string | |||
StatementTimeout time.Duration | |||
MultiStatementMaxSize int | |||
NoLock bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document this new parameter in the README
@@ -453,6 +469,7 @@ func (p *Postgres) Drop() (err error) { | |||
// Note that this function locks the database, which deviates from the usual | |||
// convention of "caller locks" in the Postgres type. | |||
func (p *Postgres) ensureVersionTable() (err error) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove this unnecessary change
Essentially a copy of Mysql no-lock parameter, but for Postgres.
Opened issue addressing this: #1001