Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(code): Fix "copy text" button in dialogs and read_only_depends_on #26467

Merged
merged 4 commits into from
May 20, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented May 17, 2024

  • Use BaseControl.get_status instead of using custom code to detect read-only field, which won't work in dialogs.
  • Use BaseControl.get_model_value and BaseControl.get_value instead of frappe.model.get_value, which won't work in dialogs.
  • Rename method to setup_copy_button, the name used in ControlData.
  • Show/hide dynamically based on read_only_depends_on by moving setup_copy_button call to refresh.

@ankush ankush requested a review from rutwikhdev May 17, 2024 10:03
@rutwikhdev rutwikhdev merged commit c4492cc into frappe:develop May 20, 2024
25 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants