feat: ignore tar: file changed as we read it during backups
#26462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to occur when new files are being created as we're archiving the files on a site. Doesn't make sense to fail the entire backup because of that. Signed-off-by: Akhil Narang <me@akhilnarang.dev>
github-actions
bot
added
the
add-test-cases
ankush
reviewed
May 17, 2024
ankush
reviewed
May 17, 2024
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
added
backport version-15-hotfix
akhilnarang
added a commit
that referenced
this pull request
May 22, 2024
#26462) (#26495) * feat: ignore `tar: file changed as we read it` during backups This seems to occur when new files are being created as we're archiving the files on a site. Doesn't make sense to fail the entire backup because of that. Signed-off-by: Akhil Narang <me@akhilnarang.dev> (cherry picked from commit 803b45b) * fix: add `errors=replace` to decode() call Signed-off-by: Akhil Narang <me@akhilnarang.dev> (cherry picked from commit e3e6834) --------- Co-authored-by: Akhil Narang <me@akhilnarang.dev>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 28, 2024
# [15.29.0](v15.28.0...v15.29.0) (2024-05-28) ### Bug Fixes * Appropriate variable name, avoid redefining parameter ([a75c031](a75c031)) * child table field wildcard in API ([#26543](#26543)) ([#26560](#26560)) ([20ac585](20ac585)) * Drop file_manager.download_file ([#26575](#26575)) ([#26577](#26577)) ([6ace16b](6ace16b)) * ignore apps without pyproject ([#26498](#26498)) ([#26503](#26503)) ([6c3c798](6c3c798)) * reload before saving on reconnect ([#26534](#26534)) ([#26537](#26537)) ([22e278f](22e278f)) * Use true stderr for dumping trace ([#26524](#26524)) ([#26527](#26527)) ([e7e55db](e7e55db)) ### Features * Add `on_add_row` event for grid in Dialog ([e592b87](e592b87)) * ignore `tar: file changed as we read it` during backups (backport [#26462](#26462)) ([#26495](#26495)) ([30f767e](30f767e)) * Option to make webform embeddable ([f08fff5](f08fff5)) ### Performance Improvements * Avoid coalesce for `between` filters ([#26531](#26531)) ([#26532](#26532)) ([8263898](8263898))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to occur when new files are being created as we're archiving
the files on a site. Doesn't make sense to fail the entire backup
because of that.
Previous behaviour would lead to the backup not being deleted from the
server, causing it to eventually run out of space. Since that was
changed, it would lead to just no backups being created for some span
of time, seems better to have most files backed up rather than no
backup.