fix: 🐛 refresh after setting read only #26439
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no refresh occurs, the form behaves in a strange way such as: * fields only become read only after chaning and leaving them * clicking "Add Row" in a child table vanishes after clicking it
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
IMHO this should still be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no refresh occurs, the form behaves in a strange way such as:
Frappe itself already has the problem that this method gets called, but doesn't have the desired effect.
Examples:
frappe/core/doctype/page/page.jsfrappe/core/doctype/doctype/doctype.jsIn ERPNext some calls to it can be found where
refresh_fields()is implicitely called afterwards. I guess to circumvent this problem.Affected Versions:
Screencast
set_read_only.mp4