Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated the Status Bar design #15419

Merged
merged 4 commits into from
May 19, 2024
Merged

Feature: Updated the Status Bar design #15419

merged 4 commits into from
May 19, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 16, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Updated the Status Bar design
  • This is prep work for completely floating panes

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed the corner radius is set to 0 when the sidebar is collapsed
  2. Confirmed the sidebar resizer height matches the border height
  3. Confirmed the border thickness is correct when Dual Pane mode is enabled
  4. Confirmed the border thickness is correct when the Info Pane is opened

Screenshots
image

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm a bit concerned that if all items are expanded, there is no visual separator between the footer content and the sidebar items, but I think that is quite hard to solve. Overall, I think it looks quite well though.

Besides that, I think its good. I'm not too happy with the name FooterContent (since Footer is also something one could expect in the left pane) but I also can't think of anything more fitting.

src/Files.App/Views/PaneHolderPage.xaml Show resolved Hide resolved
src/Files.App/Views/MainPage.xaml Show resolved Hide resolved
@0x5bfa
Copy link
Member

0x5bfa commented May 17, 2024

Yair is going to add Settings button as a pane footer.

image

As I agree with @marcelwgn on that, it should be renamed to 'ContentFooter' and pane one to be 'PaneFooter'.

@yaira2 yaira2 merged commit c737195 into main May 19, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 19, 2024
@yaira2 yaira2 deleted the ya/StatusBarDesign branch May 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants