Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new dimensions for ipad 11" screenshots support #22036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctruong90
Copy link

@ctruong90 ctruong90 commented May 17, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

This change was necessary for to add support to dimensions of screenshots that are supported by Apple appstore connect for ipad 11' screenshots

Resolves #21764

Description

I was running into errors:

US/SCREENSHOTS_IPAD_0.png - Invalid screen size (Actual size is 2360x1640 See the specifications to fix
[https://help.apple.com/app-store-connect/#/devd274dd925)�[0m|https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m]

According to https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications/, the screen size "2360x1640" is actually supported by Apple but currently not being supported with fastlane. So I updated deliver/lib/deliver/app_screenshot.rb to include the supported dimensions that are missing.

@ctruong90 ctruong90 changed the title add new dimensions for screenshots support add new dimensions for ipad 11" screenshots support May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deliver fails to upload IPad screenshots
1 participant