Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] add visionOS support for Connect API #22032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

triplef
Copy link
Contributor

@triplef triplef commented May 16, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

This is a simple rebase of #21929 onto master because the original author has not been able to do so in the past month and it would be great to have this in Fastlane to (I think?) complete visionOS support.

The only difference to the original commit is that the changes in spaceship/connect_api.rb were discarded as master already contained the same addition of visionOS.

Description

See #21929.

All credit goes to @yanniks for implementing the changes.

Testing Steps

I have used it to upload our visionOS app to App Store Connect using deliver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants