Remove deprecated dispatchCommand for INT #44519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D15955444 introduced support for View Manager Commands that are strings. > We need to support ints and Strings to be backwards compatible, but ints will be deprecated. This was deprecated 5 years ago in D16019254. While on [backwards compatibility of UIManagerModule](https://docs.google.com/document/d/1PoFDF_Ek2U-u1BOgDCYx-EgvXMMiXsSAcBkamtMq5-M/edit#heading=h.txujclhzs5ov), this was identified as `Deprecated` method that we can get rid. - dispatchCommand(int reactTag, ~~int~~ String commandId, Nullable ReadableArray commandArgs) ; - receiveCommand(NonNull T root, ~~int~~ String commandId, Nullable ReadableArray args) - dispatchViewManagerCommand( int reactTag, ~~Dynamic~~ String commandId, Nullable ReadableArray commandArgs) NOTE: This might need more JS changes. - In RNLiveMapsView & RNLMARStageView used the String directly in switch casing instead of Enum - In fb4A removed all occurrences in ViewManagers. **PENDING:** I believe, post this, we can also get rid of `getCommandsMap() ` Over-ride as well however I see it's introduction [dates before](https://www.internalfb.com/code/fbsource/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java?lines=303-313) adding Strings type, hence leaving that untouched. Differential Revision: D57150941
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57150941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D15955444 introduced support for View Manager Commands that are strings.
This was deprecated 5 years ago in D16019254.
While on backwards compatibility of UIManagerModule, this was identified as
Deprecatedmethod that we can get rid.dispatchCommand(int reactTag,
intString commandId, Nullable ReadableArray commandArgs) ;receiveCommand(NonNull T root,
intString commandId, Nullable ReadableArray args)dispatchViewManagerCommand(
int reactTag,
DynamicString commandId, Nullable ReadableArray commandArgs)NOTE: This might need more JS changes.
In RNLiveMapsView & RNLMARStageView used the String directly in switch casing instead of Enum
In fb4A removed all occurrences in ViewManagers.
PENDING:
I believe, post this, we can also get rid of
getCommandsMap()Over-ride as well however I see it's introduction dates before adding Strings type, hence leaving that untouched.Differential Revision: D57150941