[Suggestion] [Library] Set watched episodes to 0 when moving out of completed #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When anime is moved from completed, its usually to either rewatch or rewatch in the future, I dont see a reason to keep old watched episode count.
|
This would lose watch progress if the reason it's moved out of completed is because the entry got modified (e.g new OVA episodes that got added to an existing entry, so number of episodes change) |
Fix for an oversight where if the number of episodes for title has increased (like OVA getting new episodes for example) the watched episode count shouldnt be reset.
Good catch! That didn't even cross my mind. The latest commit should address said issue. |
|
There are already two explicit ways to start a rewatch (via the context menu or the anime information dialog) and both of them automatically reset watched episodes. I don't think we should make additional assumptions about the user's intention here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an anime is moved from "Completed", it's typically because it's being rewatched (or will be rewatched in the future). In most cases, I don't see the need to retain the count of previously watched episodes. This code is more of a demonstration rather than a comprehensive implementation (for obvious reasons) but it works completely.