Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests that check if Taiga.moe works as expected #1074

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Statharas
Copy link

Hi Eren,

I have added two simple Specflow tests and the pipeline to run them via github actions that check if the website is online or not.

@Statharas
Copy link
Author

For maintenance, please take a look at the feature file included

@erengy
Copy link
Owner

erengy commented Oct 23, 2022

Hi Stathis, thanks for the pull request.

I'm trying to understand how this works. Am I right to assume that the workflow runs after pushes and PRs by sending HTTP requests to taiga.moe?

If so, I'm afraid it wouldn't help, since the repository is not updated frequently. We'd have to be very lucky for these two occurences to coincide, and visiting GitHub to check the test results is not much better than simply visiting taiga.moe.

More importantly, the website has been offline only a few times in the past couple of years, and Taiga does not rely on it except for infrequent updates. I don't think automated tests of this kind is necessary.

Since the website has its own repository at erengy/taiga-moe, it'd be more appropriate to run related tests there instead of here. But once again, I don't think that'd be valuable.

@Statharas
Copy link
Author

Hi Eren,

You are correct, but it can be set up to run whenever, and can be set up to receive e-mails in case the website is not accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants