Fix some minor build system annoyances #1027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves potential issues with vsvarsall generating oversized environment variables with multiple runs.
This removes a manual step for first-time debugging and allows quick testing of theme changes. It is only supported for x86/x64 builds.
This runs only if libcurl_a.lib is not found in its expected location. It is only compatible with x86/x64 builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it mildly annoying to have to run some steps manually before and after the main build, so this PR automates these steps for non-ARM builds (on ARM, MSBuild pre-/post-build steps don't seem to be supported).
It also fixes an issue in the dependency build script where the environment is modified for the whole session, which can cause it to fail due to
vcvarsalltrying to make (I assume)PATHtoo long when called multiple times.