Extend the Health API basic YAML tests #108811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
nielsbauman
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
approved these changes
May 20, 2024
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/health/10_basic.yml
Show resolved
Hide resolved
|
Hm, this is different than I expected, why did you create a health folder for ilm and slm and did not add just another yaml file in the existing folder? |
Didn't put too much thought into it tbh, but I thought it made sense because those folders are testing different features. Is there any reason I shouldn't do that? |
I do not think they are different features. It's the health of ILM in one case and SLM in the other. I think it makes sense to keep them together. Don't you think? |
|
I don't have a strong opinion; I'm fine with either. I've moved them to the |
gmarouli
approved these changes
May 20, 2024
mark-vieira
approved these changes
May 20, 2024
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
May 21, 2024
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
May 28, 2024
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
May 28, 2024
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 29, 2024
* Extend the Health API basic YAML tests (#108811) The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators. * Fix YAML syntax * Merge and bump Health API YAML tests (#109009) * Remove data stream checks due to missing module
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 29, 2024
* Extend the Health API basic YAML tests (#108811) The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators. * Merge and bump Health API YAML tests (#109009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health node might not have received the health info from all nodes yet before the execution of this test, resulting in an "unknown" status. We make the status assertion more lenient to allow for this uncertainty. Additionally, we add some more assertions for the basic response structure of the other indicators.
Fixes #107796