Avoid using dynamic templates for semantic text fields #108771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
:Search/Mapping
carlosdelest
changed the title
|
Pinging @elastic/es-search (Team:Search) |
carlosdelest
commented
May 17, 2024
There was a problem hiding this comment.
Refactored this class to make it a base test case
| @@ -143,66 +137,4 @@ public void testBulkOperations() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| private void storeSparseModel() throws Exception { | |||
There was a problem hiding this comment.
Refactored out some utility classes to be reused
Mikep86
approved these changes
May 20, 2024
|
|
||
| protected abstract String getTypeName(); | ||
|
|
||
| protected abstract String getMapping(); |
There was a problem hiding this comment.
Nit: The format of the string returned by this method is quite specific and could trip people up in the future. Would a Map<String, Object> return type here work? We could then convert it to JSON in the abstract class. WDYT?
There was a problem hiding this comment.
I've been thinking about this too - I'd like to have more use cases before reaching a decision about the format. I don't see a particular advantage on using something similar to MapperTestCase.minimalMapping(), at least for now.
jedrazb
pushed a commit
to jedrazb/elasticsearch
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids
semantic_textfields to be used in dynamic templates.We need the
semantic_textfields to be already in the mapping so we can perform inference, so we're disallowing it based on the work done in #107491 .I've refactored some of the existing tests so we can ensure that the field mapper does comply with the requirements, and created some utilities for dealing with inference services.