fontformat: show custom fonts only #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagenihisomi
force-pushed
the
dev
branch
3 times, most recently
from
901dcec
to
757e747
Compare
moathdarwesh
approved these changes
Feb 6, 2024
dmMaze
reviewed
Apr 7, 2024
| @@ -348,6 +362,19 @@ def on_fontfamily_changed(self): | |||
| self.apply_fontfamily() | |||
|
|
|||
|
|
|||
| def showPopup(self): | |||
There was a problem hiding this comment.
Will "show all fonts" be applied properly? After you check and uncheck "show only custom fonts" will all fonts be listed again? I haven't run it locally but it seems there are no means to restore all fonts here. Also, it's probably not a good idea to reset the font list every time it popup, it should be updated only once when let_show_only_custom_fonts.stateChanged triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow font format box to show only custom fonts
Setting default is to show all fonts